[CH-384] add filecache and link jemalloc in the same order as CH #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport ClickHouse#35755 to 22.3: Fix bug in conversion from custom types to string
Backport ClickHouse#35815 to 22.3: Fix cgroups cores detection
Backport ClickHouse#35770 to 22.3: Fix enable LLVM for JIT compilation in CMake
Refactor releasing process
Simplify strip for new packages
…l_flag Resurrect build hash
…ash_v2 One more try to resurrect build hash
New package clickhouse-keeper
Docker release and regular builds
Fix automatic bucket prefix for master
support xxhash64/hash
Fully support from_unixtime and arrayJoin
Upgrade substrait proto by velox Co-authored-by: shuai.li <[email protected]>
Co-authored-by: shuai.li <[email protected]>
Support functions position/locate
…House#354) ShuffleSplitter improvement: support multiple subdirs
Support full join with join condition Co-authored-by: shuai.li <[email protected]>
|
Can one of the admins verify this patch? |
liuneng1994
reviewed
Mar 31, 2023
| String region_name; | ||
| const char * amazon_suffix = ".amazonaws.com"; | ||
| const char * amazon_prefix = "https://s3."; | ||
| if (endpoint.find(amazon_suffix) != std::string::npos) |
liuneng1994
reviewed
Mar 31, 2023
| @@ -165,7 +234,7 @@ void registerReadBufferBuildes(ReadBufferBuilderFactory & factory) | |||
| factory.registerBuilder("hdfs", [](DB::ContextPtr context_) { return std::make_shared<HDFSFileReadBufferBuilder>(context_); }); | |||
|
|
|||
| #if USE_AWS_S3 | |||
| factory.registerBuilder("s3", [](DB::ContextPtr context_) { return std::make_shared<S3FileReadBufferBuilder>(context_); }); | |||
| factory.registerBuilder("s3a", [](DB::ContextPtr context_) { return std::make_shared<S3FileReadBufferBuilder>(context_); }); | |||
There was a problem hiding this comment.
可以 但是因为spark上层好像只认s3a 不认s3 ，所以这里加了以后，相当于没有测试到
liuneng1994
reviewed
Mar 31, 2023
| @@ -165,7 +234,7 @@ void registerReadBufferBuildes(ReadBufferBuilderFactory & factory) | |||
| factory.registerBuilder("hdfs", [](DB::ContextPtr context_) { return std::make_shared<HDFSFileReadBufferBuilder>(context_); }); | |||
|
|
|||
| #if USE_AWS_S3 | |||
| factory.registerBuilder("s3", [](DB::ContextPtr context_) { return std::make_shared<S3FileReadBufferBuilder>(context_); }); | |||
| factory.registerBuilder("s3a", [](DB::ContextPtr context_) { return std::make_shared<S3FileReadBufferBuilder>(context_); }); | |||
…AD, and set ENABLE_JEMALLLOC=OFF,and JEMALLOC_ATTR(constructor(101)) in jemallo.c)
…le PRELOAD, and set ENABLE_JEMALLLOC=OFF,and JEMALLOC_ATTR(constructor(101)) in jemallo.c)" This reverts commit f242fcc.
binmahone
force-pushed
the
230327_support_s3_and_cache
branch
from
d5905eb to
21d5919
Compare
liuneng1994
force-pushed
the
clickhouse_backend
branch
from
6528ff0 to
52be833
Compare
lwz9103
force-pushed
the
clickhouse_backend
branch
2 times, most recently
from
dc60d55 to
8066113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes